Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[oneMKL][RNG][Spec] Added oneMKL RNG Device APIs #493

Merged
merged 4 commits into from
Sep 5, 2023
Merged

[oneMKL][RNG][Spec] Added oneMKL RNG Device APIs #493

merged 4 commits into from
Sep 5, 2023

Conversation

iMartyan
Copy link
Contributor

@iMartyan iMartyan commented Sep 1, 2023 •
edited
Loading

  • Divided Host APIs and Device APIs into separate directories
  • Minor cosmetic changes to Host APIs
  • Added Device APIs based on oneMKL Developer Reference

@iMartyan iMartyan changed the title initial commit [oneMKL][RNG][Spec] Added oneMKL RNG Device APIs Sep 1, 2023
@iMartyan
Copy link
Contributor Author

iMartyan commented Sep 1, 2023

@paveldyakov, @aelizaro, @andreyfe1, Could you please review changes?

paveldyakov
paveldyakov reviewed Sep 4, 2023
View reviewed changes
source/elements/oneMKL/source/domains/rng/device_routines/device-bibliography.rst Outdated Show resolved Hide resolved
...oneMKL/source/domains/rng/device_routines/device-distributions-template-parameter-method.rst Outdated Show resolved Hide resolved
...oneMKL/source/domains/rng/device_routines/device-distributions-template-parameter-method.rst Outdated Show resolved Hide resolved
...oneMKL/source/domains/rng/device_routines/device-distributions-template-parameter-method.rst Outdated Show resolved Hide resolved
...oneMKL/source/domains/rng/device_routines/device-distributions-template-parameter-method.rst Outdated Show resolved Hide resolved
source/elements/oneMKL/source/domains/rng/device_routines/device-distributions.rst Outdated Show resolved Hide resolved
source/elements/oneMKL/source/domains/rng/device_routines/device-rng-bits.rst Outdated Show resolved Hide resolved
source/elements/oneMKL/source/domains/rng/device_routines/device-rng-usage-model.rst Outdated Show resolved Hide resolved
andreyfe1
andreyfe1 reviewed Sep 4, 2023
View reviewed changes
source/elements/oneMKL/source/domains/rng/host_routines/manual-offload-routines.rst Outdated Show resolved Hide resolved
source/elements/oneMKL/source/domains/rng/device_routines/device-bibliography.rst Outdated Show resolved Hide resolved
...oneMKL/source/domains/rng/device_routines/device-distributions-template-parameter-method.rst Outdated Show resolved Hide resolved
...oneMKL/source/domains/rng/device_routines/device-distributions-template-parameter-method.rst Outdated Show resolved Hide resolved
...oneMKL/source/domains/rng/device_routines/device-distributions-template-parameter-method.rst Outdated Show resolved Hide resolved
source/elements/oneMKL/source/domains/rng/device_routines/device-rng-mcg31m1.rst Outdated Show resolved Hide resolved
source/elements/oneMKL/source/domains/rng/device_routines/device-rng-mcg31m1.rst Outdated Show resolved Hide resolved
source/elements/oneMKL/source/domains/rng/device_routines/device-rng-uniform-bits.rst Outdated Show resolved Hide resolved
source/elements/oneMKL/source/domains/rng/device_routines/device-rng-uniform-continuous.rst Outdated Show resolved Hide resolved
source/elements/oneMKL/source/domains/rng/device_routines/device-rng-usage-model.rst Outdated Show resolved Hide resolved
aelizaro
aelizaro reviewed Sep 4, 2023
View reviewed changes
...oneMKL/source/domains/rng/device_routines/device-distributions-template-parameter-method.rst Outdated Show resolved Hide resolved
...oneMKL/source/domains/rng/device_routines/device-distributions-template-parameter-method.rst Outdated Show resolved Hide resolved
source/elements/oneMKL/source/domains/rng/device_routines/device-rng-bits.rst Outdated Show resolved Hide resolved
source/elements/oneMKL/source/domains/rng/device_routines/device-rng-bits.rst Outdated Show resolved Hide resolved
source/elements/oneMKL/source/domains/rng/device_routines/device-rng-exponential.rst Outdated Show resolved Hide resolved
source/elements/oneMKL/source/domains/rng/device_routines/device-rng-lognormal.rst Outdated Show resolved Hide resolved
source/elements/oneMKL/source/domains/rng/device_routines/device-rng-lognormal.rst Outdated Show resolved Hide resolved
source/elements/oneMKL/source/domains/rng/device_routines/device-rng-uniform-discrete.rst Outdated Show resolved Hide resolved
source/elements/oneMKL/source/domains/rng/device_routines/device-rng-usage-model.rst Outdated Show resolved Hide resolved
source/elements/oneMKL/source/domains/rng/onemkl-rng-overview.rst Show resolved Hide resolved
aelizaro
aelizaro reviewed Sep 4, 2023
View reviewed changes
Copy link
Contributor

@aelizaro aelizaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, check bibliography.rst, maybe it is lost in PR

source/elements/oneMKL/source/domains/rng/onemkl-rng-overview.rst Outdated Show resolved Hide resolved
source/elements/oneMKL/source/domains/rng/host_api/rng-host-routines.rst Show resolved Hide resolved
source/elements/oneMKL/source/domains/rng/device_api/device-rng-usage-model.rst Outdated Show resolved Hide resolved
paveldyakov
paveldyakov approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@paveldyakov paveldyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great work, Ivan!

@iMartyan
Copy link
Contributor Author

iMartyan commented Sep 5, 2023

please, check bibliography.rst, maybe it is lost in PR

Thanks. It is not lost, just was returned to its original state, so no appearance in PR.
You can find it in the branch

andreyfe1
andreyfe1 approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@andreyfe1 andreyfe1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks. Great work!

@spencerpatty
Copy link
Contributor

Does this change the spec in any way taht would need us to update minor or major release value ?

@paveldyakov
Copy link
Contributor

@spencerpatty, if I am not mistaken the coming version is oneAPI 1.3 provisional update
I think it is a good context for the 1.3 version as we are extending the oneMKL specification with RNG Device API

@spencerpatty spencerpatty merged commit e494df3 into uxlfoundation:main Sep 5, 2023
3 checks passed
aepanchi pushed a commit to aepanchi/oneAPI-spec that referenced this pull request Oct 31, 2023
@iMartyan @aepanchi
[oneMKL][RNG][Spec] Added oneMKL RNG Device APIs (uxlfoundation#493)
eb34814
@mkrainiuk mkrainiuk mentioned this pull request Jul 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paveldyakov paveldyakov paveldyakov approved these changes

@aelizaro aelizaro aelizaro approved these changes

@andreyfe1 andreyfe1 andreyfe1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iMartyan @spencerpatty @paveldyakov @andreyfe1 @aelizaro